florent/pages
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Socials icons: Check if rss_icon: false (#3282)

Browse Source 
Partially addresses issue #3280.

Currently, the RSS feed icon in the socials section will show whenever
`rss_icon` in `data/_socials.yml` has a value --- **even if that value
is `false`**.

Unlike the other social settings, which are empty by default, for
`rss_icon` the default setting is `true`.

So it makes sense that a user might expect `rss_icon: false` to disable
said icon.

This PR just adds a check if the value is `false` and hides the icon if
so.
This commit is contained in:
Scott Lee Chua 2025-09-01 23:22:19 +08:00 committed by GitHub
parent 859a245f65
commit db2a1d1b19
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
_includes/social.liquid
View File

@ -59,7 +59,9 @@
{% when 'research_gate_profile' %} {% when 'research_gate_profile' %}
<a href="https://www.researchgate.net/profile/{{ social[1] }}/" title="ResearchGate"><i class="ai ai-researchgate"></i></a> <a href="https://www.researchgate.net/profile/{{ social[1] }}/" title="ResearchGate"><i class="ai ai-researchgate"></i></a>
{% when 'rss_icon' %} {% when 'rss_icon' %}
<a href="{{ site.baseurl }}/feed.xml" title="RSS Feed"><i class="fa-solid fa-square-rss"></i></a> {% if social[1] == true %}
<a href="{{ site.baseurl }}/feed.xml" title="RSS Feed"><i class="fa-solid fa-square-rss"></i></a>
{% endif %}
{% when 'scholar_userid' %} {% when 'scholar_userid' %}
<a href="https://scholar.google.com/citations?user={{ social[1] }}" title="Google Scholar"><i class="ai ai-google-scholar"></i></a> <a href="https://scholar.google.com/citations?user={{ social[1] }}" title="Google Scholar"><i class="ai ai-google-scholar"></i></a>
{% when 'scopus_id' %} {% when 'scopus_id' %}