florent/pages
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix conditional rendering of tag and category section (#2678)

Browse Source 
### Overview
This PR fixes an issue where unnecessary horizontal lines were displayed
when there were no tags or categories present. The tag and category
container is now conditionally rendered, ensuring it only appears when
there are tags or categories to display.

no tags meaning, in _config.yml
```
display_tags: []
display_categories: []
```

### Before and After
The difference is illustrated in the images below:
- **First Image (Fixed)**: Shows the correct behavior with no extra
lines when tags or categories are absent.
- **Second Image (Current)**: Demonstrates the issue with unwanted
horizontal lines appearing when no tags or categories are present.


![image](https://github.com/user-attachments/assets/08becad5-9a34-4b6c-8a69-25206d9097da)

![image](https://github.com/user-attachments/assets/e36390cc-3104-4aa2-a047-a7fa8289e664)

### Impact
This change improves the visual consistency and cleanliness of the theme
by preventing unnecessary elements from being rendered, particularly in
cases where there are no tags or categories defined.
This commit is contained in:
Gürkan Soykan 2024-09-10 16:57:54 +02:00 committed by GitHub
parent 7203eb161c
commit f0eb587573
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
_pages/blog.md
View File

@ -29,7 +29,7 @@ pagination:
</div> </div>
{% endif %} {% endif %}
{% if site.display_tags or site.display_categories %} {% if site.display_tags and site.display_tags.size > 0 or site.display_categories and site.display_categories.size > 0 %}
<div class="tag-category-list"> <div class="tag-category-list">
<ul class="p-0 m-0"> <ul class="p-0 m-0">