Commit Graph

4 Commits

Author SHA1 Message Date
George
bbaae0afa9
Fixed prettier actions (#2113)
After some thorough testing, finally made prettier on PR work. Since an
html file can't be used as comment on GitHub, changed to simply point to
the action that failed and to the file containing the html diff.

Signed-off-by: George Araújo <george.gcac@gmail.com>
2024-01-22 17:45:34 -03:00
George
27d2fa093d
Changed how prettier comments on PR works (#2112)
Signed-off-by: George Araújo <george.gcac@gmail.com>
2024-01-22 14:49:34 -03:00
George
7ed8f49e72
Update prettier-on-pr.yml permissions 2024-01-22 13:40:33 -03:00
George
8af6b73fd6
Prettier check now generates a diff comment on PR (#2085)
Splitted prettier GitHub action into two:
- `on push`, only runs on direct pushes, if test fails generates an
artifact (that lasts for 3 days) with an html version of the changes
needed to pass prettier test
- `on PR`, only runs on PRs, if test fails comments on the PR with the
HTML content of the diff

I couldn't actually test the `on PR` version since it needs to be on a
PR in the master branch, so this will only be triggered after this PR is
accepted, and for the next PR that fails prettier test.

PS: currently the artifact is a zip file with the html inside. It is not
currently possible to generate it other way, we have to wait for [this
issue](https://github.com/actions/upload-artifact/issues/14) to be
closed.

---------

Signed-off-by: George Araújo <george.gcac@gmail.com>
2024-01-22 13:30:24 -03:00